Add matrix testing for VSS authorizer variants#786
Add matrix testing for VSS authorizer variants#786enigbe wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
Run VSS integration tests against multiple server authorizer configurations (noop, sig, jwt). Each matrix job builds the vss-server with the appropriate flags and passes the corresponding cfg flag to the test runner. - Use release builds for vss-server - Pass authorizer-specific cfg flags for test differentiation - Add `test_utils` feature with JWT and signature-based header generation - Add RSA keypair fixtures for JWT signing - Update VSS tests to use auth-aware headers
|
I've assigned @tnull as a reviewer! |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Hmm, we're about to upstream VssStore to lightning-persister, and we're just waiting for #755 before doing that. So I'd rather not add more complexity here that we then have to migrate. Could make sense to add it to lightning-persister afterwards, although I have to say I'm not fully sold.
|
Figured I'd fix the failing test after noticing failure on commits in mine and other PRs. I'll just close this given that with #755 landing, we'd have no need for this. |
Yeah, thank you for that! |
3 participants
What this PR does
With the addition of a public key-based authenticator and the option to verify JWT tokens on
vss-server, the defaultvss-serverbuild now requires authentication, so our integration tests need to either provide valid headers or explicitly build for theno-opauthenticator. This is why the VSS CI has been failing lately.To address this, we run VSS integration tests against multiple server authorizer configurations (noop, sig, jwt). Each matrix job builds
vss-serverwith the appropriate flags and passes the correspondingcfgflag and features to the test runner.The summary of changes introduced include:
cfgflags and features for test differentiationtest_utilsfeature with JWT- and signature-based header generation